search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

hope-tab text color should be set dynamically based on theme-color #25

Open wilsonpage opened 8 years ago

wilsonpage commented 8 years ago

A light theme color should have dark text and a dark theme color should have light text.

wilsonpage commented 8 years ago

Here's a lightness test. I don't know enough about colors to know if it's good or not.

wilsonpage commented 8 years ago

It seems to declare red as 'light', but per our design I think we regard that as 'dark'. So it may need some tweaking.

jonathanKingston commented 8 years ago

The algo defines for CSS contrast() might be worth looking at as an alternative here: https://drafts.csswg.org/css-color-4/#contrast-adjuster

I suspect that won't give as nice shades as just white and black text though but interesting prior art all the same.

jonathanKingston commented 8 years ago

Also this is interesting and relevant: https://blog.mozilla.org/ux/2015/12/firefox-os-customization-concept/ (However the text color doesn't seem to change)

etiennesegonzac commented 8 years ago

@jonathanKingston yep, Peter La is also working on this project so it might very well happen :)

pivanov commented 8 years ago

Hey guys, If you need some help about tweaking colors just ping me :)

etiennesegonzac commented 8 years ago

@pivanov Feel free to give it a try! And let me know if there's anything blocking.