search

kite-sdk / kite-examples

Kite SDK Examples
Apache License 2.0
99 stars 70 forks source link

CDK-514: Use views #6

Closed rdblue closed 10 years ago

rdblue commented 10 years ago

I've run through the examples updated here (except for the maven parts of dataset-hbase), although we will need to again after CDK-496 is merged. Everything works.

tomwhite commented 10 years ago

Thanks for doing this @rdblue. It's pretty close - please see my comments above.

tomwhite commented 10 years ago

I think there's a longer discussion to be had regarding use of core-site properties in the examples, but in the interests of moving this forward let's go with what you have here.

Can you also add my commit for dataset-staging timezones please (https://github.com/tomwhite/kite-examples/commit/4f98fc33277949bf5eff57c1dc6b85a3d3d42d27)

rdblue commented 10 years ago

I've added 4f98fc3 and fixed the type parameters passed to create in dataset-staging. I think we should be able to remove those with Joey's work on CDK-496 but they are fine for now. We can fix that when doing final release testing.