search

kite-sdk / kite

Kite SDK
http://kitesdk.org/docs/current/
Apache License 2.0
394 stars 263 forks source link

KITE-1035 added kite configuration service for oozie to supplement the KiteURIHandler #405

Closed bbrownz closed 8 years ago

bbrownz commented 9 years ago

https://issues.cloudera.org/browse/KITE-1035

Alternative implementation of the concept introduced first in pull #399

Sets the default configuration for kite to a list of configuration sources set at the property "oozie.service.KiteConfigurationService.kite.configuration"

(A consumer would also need to add the configuration service to the list of configurations specified for oozie under "oozie.services")

bbrownz commented 9 years ago

@rkanter @rdblue This is the branch with the Kite specific oozie configuration alternative to #399

It looks like the Flume tests bombed out on an OOM on the Travis build, it looks like #398 hit something similar, maybe the travis setup needs some adjustments?

rdblue commented 9 years ago

Yeah, don't worry about the Flume test failure. I'll restart it but I doubt it's related.

rkanter commented 9 years ago

I made a few minor comments. Otherwise, that looks good to me. +1 after addressing them.

bbrownz commented 9 years ago

Updates for Roberts comments are covered in 7061b11. Thanks @rkanter!

bbrownz commented 9 years ago

@rdblue Did we have anything else we wanted to look at with this PR before it gets merged in?

rdblue commented 9 years ago

@bbrownz, I think we're ready to go. I've just been a bit swamped lately.

bbrownz commented 8 years ago

@rdblue no worries, just checking in to make sure I wasn't missing anything

mkwhitacre commented 8 years ago

+1 for merging.

mkwhitacre commented 8 years ago

@rdblue or @tomwhite any objections to me merging this?

rdblue commented 8 years ago

Nope, go for it!