search

kite-sdk / kite

Kite SDK
http://kitesdk.org/docs/current/
Apache License 2.0
394 stars 263 forks source link

KITE-1057: Fix signal path for single data file. #413

Closed rdblue closed 8 years ago

rdblue commented 9 years ago

The CLI will create a dataset around a single data file, but the FileSystemDataset code assumed that the path it uses is a directory. This caused errors because the signal manager attempted to use the incoming data file path as a directory that potentially contained the signals folder. This updates the FileSystemDataset to use the data file's parent for the signal path.

tomwhite commented 8 years ago

Looks good. What testing have you done?

rdblue commented 8 years ago

Tested on 5.5 and 5.4.6. That's how I found the other issue. :)

tomwhite commented 8 years ago

+1