search

kiteco / kite-connect-js

JS connector module to Kite client
BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Quote spaces in Windows path #17

Closed itsdhung closed 5 years ago

itsdhung commented 5 years ago

Fixes issue where KiteSetup.exe could not be run if the user name had spaces in it

ToDo

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17      +/-   ##
=======================================
+ Coverage   77.96%   78%   +0.04%     
=======================================
  Files          16    16              
  Lines         581   623      +42     
=======================================
+ Hits          453   486      +33     
- Misses        128   137       +9
Impacted Files Coverage Δ
lib/support/osx.js 82.35% <ø> (ø) :arrow_up:
lib/support/windows.js 68.88% <100%> (ø) :arrow_up:
lib/index.js 80.95% <0%> (-2.13%) :arrow_down:
lib/utils.js 80.15% <0%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35924f3...d543e17. Read the comment docs.