search

kiteco / kite-connect-js

JS connector module to Kite client
BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Add promise rejection for process errors #37

Closed edzkite closed 4 years ago

edzkite commented 4 years ago

Add handling and logging @ https://github.com/kiteco/kite-connect-js/compare/proc-err-logging?expand=1#diff-50e3aa130a4f97a42ee2cf111c7b1d9dR209 to help debug the Rollbar issues. Previously, we had no handling in the event that an error occurs when a child process is spawned.

codecov-io commented 4 years ago

Codecov Report

Merging #37 into master will decrease coverage by 0.06%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage    73.5%   73.44%   -0.07%     
==========================================
  Files          17       17              
  Lines         721      723       +2     
==========================================
+ Hits          530      531       +1     
- Misses        191      192       +1
Impacted Files Coverage Δ
lib/utils.js 79.68% <87.5%> (-0.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdb0e07...81cf4bd. Read the comment docs.