kitesurfer1404 / WS2812FX

WS2812 FX Library for Arduino and ESP8266
MIT License
1.58k stars 344 forks source link

esp8266_webinterface: SoftAP & auto cycling #302

Closed FedericoBusero closed 2 years ago

FedericoBusero commented 2 years ago

While creating some smart textile application (aka an ugly Xmas Sweater ;-) some improvements were necessary:

moose4lord commented 2 years ago

Thanks for contributing to WS2812FX.

I'm hesitant to make your SoftAP changes to the esp8266_webinterface example sketch. That sketch is pretty complicated to begin with and I'd rather not add more complexity by adding the SoftAP code. My feeling is that the example sketches should be as simple as possible to demonstrate an aspect or feature of the library. They're not meant to be full fledged applications with lots of bells and whistles.

I like your tweak to the auto-cycle code. Do you think auto-cycling should be disabled for other UI changes besides mode? Should changes to color, brightness or speed also disable auto-cycle?

FedericoBusero commented 2 years ago

No problem regarding the SoftAP functionality, I understand that you want to keep it as simple as possible.

Regarding auto-cycling: it's only when selecting a specific mode that it should stop cycling the modes. When changing color/speed/brightness, it is just interesting to see the impact on the different modes.

moose4lord commented 2 years ago

I didn't know how to separate the SoftAP code from the auto-cycle code, so I copied the auto-cycle fix into my own PR and pushed it. Hope that's ok.