search

kitesurfer1404 / WS2812FX

WS2812 FX Library for Arduino and ESP8266
MIT License
1.6k stars 347 forks source link

Adapt for WS2801 #37

Closed r41d closed 6 years ago

r41d commented 7 years ago

I own some WS2801 and would like to control them using this awesome library. What would be the preferred method?

  1. Including support for WS2801 in WS2812FX by abstracting the Adafruit WS2801/Neopixel library calls. This would need a method to indicate that a WS2801 should be controlled, for example via a different init method.
  2. Just port WS2812FX from Adafruit_NeoPixel to Adafruit-WS2801-Library in a fork (then being named WS2801FX)

Would the maintainer accept a PR that implemented 1.? If yes, I would work on this, if not, I would attempt 2.

r41d commented 7 years ago

Since I was in need of this project for WS2801, I decided to port it. Here is the result: https://github.com/r41d/WS2801FX Remarks appreciated.

I think if one wanted to include support for more than just WS2812 strips in this project, then porting to FastLED seems like a good choice. I ended up porting to the WS2801 library because I got most experience with the Adafruit libs and wanted to get my WS2801 strip running in time :D

kitesurfer1404 commented 7 years ago

Cool to see this being ported. I was quite busy with my photobooth project (new code coming soon). Now the time has come to start the christmas light projects, so I'll work on this lib again.

I have no WS2801 here. But I guess I'll have to look into all different kinds of "smart" LEDs soon to get this working with most of them. Next might be UCS1904, because there are some LEDs on their way from china to my door.

Porting to FastLED was suggested before. I have no experience with that lib, only with the Adafruit one. But I might switch this lib over.

Need to review all the nice pull requests and issues, soon. So many great ideas in there.