search

kitetail / zttp

A developer-experience focused HTTP client, optimized for most common use cases.
MIT License
1.68k stars 120 forks source link

Remove redundant new() static method #62

Closed tim-mortimer closed 6 years ago

tim-mortimer commented 6 years ago

I believe that this is a more concise and readable way of achieving the same result. Do you agree?

Thanks for this awesome library, and I look forward to hearing what you think!

ntzm commented 6 years ago

Removing a public method is a breaking change

adamwathan commented 6 years ago

Gonna keep this because I hate the parentheses around (new PendingZttpRequest) and PendingZttpRequest::new() feels just a little bit more like writing in a nice language like Ruby 😅

Thanks though!