P2: do not perform replacement on handler.go if -service is not specified

kitex-contrib / codec-dubbo

支持 kitex <-> dubbo 互通的 dubbo 协议编解码器。

Apache License 2.0

16 stars 14 forks source link

P2: do not perform replacement on handler.go if -service is not specified #77

Closed felix021 closed 7 months ago

felix021 commented 7 months ago

The -service option is not specified by Kitex is still trying to perform the replacement:

kitex -module test6 -protocol Hessian2 -hessian2 java_extension api.thrift Adding apache/thrift@v0.13.0 to go.mod for generated code .......... Done replace java object fail, you can fix it then regenerate open /xxx/dubbo/test6/handler.go: no such file or directory

DMwangnima commented 7 months ago

Kitex cmd tools does not consider the situation without -service flag.

DMwangnima commented 7 months ago

BTW, I think our codec-dubbo-tests should generate code automatically in CI so that problems in this part would be exposed.

felix021 commented 7 months ago

fixed in https://github.com/cloudwego/kitex/pull/1234