search

kitex-contrib / codec-dubbo

支持 kitex <-> dubbo 互通的 dubbo 协议编解码器。
Apache License 2.0
16 stars 14 forks source link

fix(zookeeper-registry): Support the options of WithoutKeepAlive for zookeeper(#86) #87

Closed s5364733 closed 5 months ago

bytedance-oss-robot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DMwangnima, s5364733 To complete the pull request process, please assign yangruiemma after the PR has been reviewed. You can assign the PR to them by writing /assign @yangruiemma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kitex-contrib/codec-dubbo/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
felix021 commented 5 months ago

This option may be dangerous: if it's set to false and accidentally deployed to online env, it may cause unexpected error.

This is not a good way to solve the original problem. A better approach would be to distinguish your local machine and testing/product env, and do not register into zk if it's not testing/product env.

DMwangnima commented 5 months ago

Development specification issues shouldn't be left to frameworks. I would close this PR and related issue.