feat(p2) Added hessian2 enumeration support for dubbo (#88)

s5364733 commented 4 months ago

Establishing a hessian2 bridge to the kitex client

Check the PR title.

[ ] This PR title match the format: \<type>(optional scope): \<description>
[ ] The description of this PR title is user-oriented and clear enough for others to understand.
[ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

s5364733 commented 4 months ago

OK

---Original--- From: "Scout @.> Date: Mon, Apr 15, 2024 20:09 PM To: @.>; Cc: @.**@.>; Subject: Re: [kitex-contrib/codec-dubbo] feat(p2) Added hessian2 enumerationsupport for dubbo (#88) (PR #89)

@DMwangnima commented on this pull request.

In pkg/hessian2/enum/enum.go: > + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + / + +package enum + +import ( + hessian "github.com/apache/dubbo-go-hessian2" +) + +const InvalidJavaEnum JavaEnum = -1
Why do we not refer to hessian.InvalidJavaEnum?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

s5364733 commented 4 months ago

因为模板生成的代码要经过codecdubbo所以这里直接考出来，避免用hessian2的包不能直接用

---Original--- From: "Scout @.> Date: Mon, Apr 15, 2024 20:09 PM To: @.>; Cc: @.**@.>; Subject: Re: [kitex-contrib/codec-dubbo] feat(p2) Added hessian2 enumerationsupport for dubbo (#88) (PR #89)

@DMwangnima commented on this pull request.

In pkg/hessian2/enum/enum.go: > + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + / + +package enum + +import ( + hessian "github.com/apache/dubbo-go-hessian2" +) + +const InvalidJavaEnum JavaEnum = -1
Why do we not refer to hessian.InvalidJavaEnum?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

bytedance-oss-robot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s5364733 To complete the pull request process, please ask for approval from dmwangnima after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kitex-contrib/codec-dubbo/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kitex-contrib / codec-dubbo