kitex-contrib / kitexcall

A command line tool for sending requests using kitex
Apache License 2.0
6 stars 5 forks source link

feat:add kitexcall version #11

Closed SHENCaesar closed 1 month ago

SHENCaesar commented 1 month ago

What type of PR is this?

Check the PR title.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

bytedance-oss-robot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SHENCaesar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kitex-contrib/kitexcall/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

Zzhiter commented 1 month ago

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

SHENCaesar commented 1 month ago

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

The lint failed is caused by misalignment of the format, has been corrected, thanks for correcting @Zzhiter

Zzhiter commented 1 month ago

@SHENCaesar lint failed: https://github.com/kitex-contrib/kitexcall/actions/runs/9436644358/job/25991876137?pr=11

The lint failed is caused by misalignment of the format, has been corrected, thanks for correcting @Zzhiter

ok, looks good to me.