search

kitex-contrib / obs-opentelemetry

An extension library of OpenTelemetry for Kitex
Apache License 2.0
24 stars 21 forks source link

recordStackTraceInSpan param do not use #4

Closed zstone12 closed 2 years ago

zstone12 commented 2 years ago

logging/logrus/option.go func WithRecordStackTraceInSpan(recordStackTraceInSpan bool) Option { return option(func(cfg *config) { cfg.traceHookConfig.recordStackTraceInSpan = true }) }

zstone12 commented 2 years ago

I think remove the param or use it cfg.traceHookConfig.recordStackTraceInSpan = recordStackTraceInSpan

CoderPoet commented 2 years ago

I think remove the param or use it cfg.traceHookConfig.recordStackTraceInSpan = recordStackTraceInSpan

Thanks for the reminder, there is indeed a problem, thanks for your PR