search

kitex-contrib / obs-opentelemetry

An extension library of OpenTelemetry for Kitex
Apache License 2.0
24 stars 21 forks source link

fix: option param #5

Closed zstone12 closed 2 years ago

zstone12 commented 2 years ago

About https://github.com/kitex-contrib/obs-opentelemetry/issues/4

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

CoderPoet commented 2 years ago

/lgtm

CoderPoet commented 2 years ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@zstone12 You may need SLA

bytedance-oss-robot[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zstone12 To complete the pull request process, please ask for approval from coderpoet after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kitex-contrib/obs-opentelemetry/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zstone12 commented 2 years ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@zstone12 You may need SLA

done.

CoderPoet commented 2 years ago

Merged, thank you very much for your PR !