search

kitex-contrib / registry-consul

Apache License 2.0
5 stars 11 forks source link

Init registry #2

Closed Hanson closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Hanson commented 2 years ago

@longlihale 老哥都好了

GuangmingLuo commented 2 years ago

All review comments need to be solved before we move on, thanks.

GuangmingLuo commented 2 years ago

@liu-song please take a look at this pr and leave your review comments if may.

liu-song commented 2 years ago

hi,@Hanson, 幸苦一下 1 把这个ci 没通过的相关点修复下，ci 也可以在自己fork 的仓库里面开启action就可以测了 2 单元测试的通过需要在CI里面先安装下 consul的服务端，不然无法通过测试 3 把相关函数的功能用英文备注下的功能

GuangmingLuo commented 2 years ago

hello, checked the latest code and resolved some conversations, more things need to be done:

  1. Please check and fix all the unresolved conversation.
  2. UT need more work in more cases、comments、clean code.
  3. Exported functions need comments.