search

kitex-contrib / registry-consul

Apache License 2.0
5 stars 11 forks source link

feat: add option for `NewConsulRegisterWithConfig` #9

Closed L2ncE closed 1 year ago

L2ncE commented 1 year ago

It seems cumbersome to use this middleware to configure tokens and use health checks at the same time. I think a new input parameter needs to be added.

Fixes #8

bytedance-oss-robot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baiyutang, L2ncE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kitex-contrib/registry-consul/blob/main/OWNERS)~~ [baiyutang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment