Closed succulentxb closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: succulentxb
The full list of commands accepted by this bot can be found here.
Nice catch.
But it seems still wrongly for demo-service
and demo-service/b
. How about adding a check to ensure character /
not in service name when register ?
@succulentxb hi, will you continue on this PR ?
@succulentxb hi, will you continue on this PR ?
Sorry for omission, I've push a new commit for checking char '/' in service name.
@succulentxb please also fix this
@succulentxb please also fix this
done
LGTM
@succulentxb Could you also help to fix the CI failure? Just add a check for the return value of pem.Encode
in etcd_resolver_test.go
@lizhemingi Is it okay that I assign return error to '_' in order to fix ci lint?
/LGTM
@succulentxb Thanks.
kitex-contrib/registry-etcd in current version facing at the bug that services will be resolved chaotically when services have names with the same prefix. For example, Service A named "demo-service" Service B named "demo-service-B" the resolver will return both Service A and Service B registry info when resolve for "demo-service".