search

kitloong / laravel-migrations-generator

Laravel Migrations Generator: Automatically generate your migrations from an existing database schema.
MIT License
2.44k stars 270 forks source link

features: sort tables before generate #154

Closed ahmadsyamim closed 1 year ago

kitloong commented 1 year ago

Hi @ahmadsyamim , thanks for the pull request. Could you please provide the reason of sort the name?

ahmadsyamim commented 1 year ago

@kitloong Using postgres on different machine, table name list is sorted differently. Causing unsorted table name on migration file which caused tracking changes difficult.

codecov[bot] commented 1 year ago

Codecov Report

Merging #154 (5d70ec7) into 6.x (6e6c773) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                6.x     #154   +/-   ##
=========================================
  Coverage     93.48%   93.48%           
  Complexity      873      873           
=========================================
  Files           114      114           
  Lines          2502     2502           
=========================================
  Hits           2339     2339           
  Misses          163      163
Impacted Files Coverage Δ
src/MigrateGenerateCommand.php 96.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kitloong commented 1 year ago

Thank you, please fix the phpcs style check.