search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.github.io/kitodo-presentation/
GNU General Public License v3.0
39 stars 45 forks source link

Replace JPlayer #1167

Open stweil opened 9 months ago

stweil commented 9 months ago

Description

JPlayer is one of the libraries used by Kitodo.Presentation. It was added to the code base in commit e7a21a478d5eb6fae9b9ff22463c4191c5d9e39a to get an audio player GUI.

That library was last released ten years ago, a related website still uses Wordpress 3.9, the last commit was seven years ago, issues and pull requests are not answered. So there are a lot of indicators that jPlayer is unmaintained.

I now made a last try here: https://github.com/jplayer/jPlayer/issues/436

If jPlayer remains unmaintained, it should be replaced because unmaintained code is a security risk. Meanwhile HTML 5 is standard, and using an extra library for an audio player might no longer be needed.

Related Issues

Expected Benefits of this Development

This is a code maintenance task, necessary to eliminate potential risks by unmaintained code.

Estimated Costs and Complexity

Hopefully the costs for this task are low (less than 5 working days).

sebastian-meyer commented 9 months ago

As far as I am aware, @fschoelzel at SLUB Dresden is working on implementing shaka-player for video. Maybe we can use that for audio as well and get rid of jPlayer that way?

stweil commented 9 months ago

Maybe. But perhaps it is sufficient to use simple HTML 5 code for audio. There even exist code generators for audio players. I updated the description above.

fschoelzel commented 8 months ago

After the implementation of the dev-mediaplayer branch (PR: #818), the default audio player is the shaka-player integration, due to common desired features between audio and video files, and also to keep the UI the same. On my current development branch, shaka-player is running on the latest version and is well maintained, but I need to remove the old JPlayer functionality.

sebastian-meyer commented 8 months ago

Votes: 0 (because this doesn't need more funding)