search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
38 stars 45 forks source link

[BUG] Reindexing options -l and -b work not with -c (or long versions) or -a #1215

Closed BFallert closed 2 weeks ago

BFallert commented 3 months ago

Description

Problem

At the moment it is not possible to reindex a large collection with -l (--index-limit) and -b (--index-begin). It is only possible to reindex the whole dataset. If the reindexing options -l (--index-limit) and -b (--index-begin) are used, a simultaneously specified parameter -c (--coll) is ignored. If -a (--all) is used together with the parameters -l (--index-limit) and -b (--index-begin), these two parameters are ignored.

Proposed Solution

It should also be possible to reindex a large collection using -l and -b. If the current behavior is desired, the documentation would have to be adapted.

Additional Context

https://github.com/kitodo/kitodo-presentation/blob/0dd0bfef744d25fb8aebc65190422f7f90011069/Classes/Command/ReindexCommand.php#L157-L186

beatrycze-volk commented 2 weeks ago

Can this issue be closed or is there still something missing?

sebastian-meyer commented 2 weeks ago

Yes, this is fixed. I just forgot to link the issue to the pull request. Sorry!