search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
37 stars 45 forks source link

JavaScript error after adding Page View Map features #147

Closed frank-ulrich-weber closed 6 years ago

frank-ulrich-weber commented 7 years ago

After adding Map features within the Page View Plugin the following JavaScript error appears: "ReferenceError: layers is not defined" within https://github.com/kitodo/kitodo-presentation/blob/master/dlf/plugins/pageview/tx_dlf_pageview.js#L101-L103 The documentation of the method tells me that it is only for fulltext and image manipulation. The Map Features like "OverviewMap" and "ZoomPanel" are not mentioned. Is that just needless code at this place? The createControls_ method is by the way called within the init() method. https://github.com/kitodo/kitodo-presentation/blob/master/dlf/plugins/pageview/tx_dlf_pageview.js#L305-L307 I comment out that piece of code and everthing is still working without JavaScript errors.

sebastian-meyer commented 6 years ago

Should be fixed with #148