search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
37 stars 45 forks source link

Add OpenLayers FullScreen Control #172

Closed albig closed 6 years ago

albig commented 7 years ago

The current used build of OpenLayers 3 in Kitodo.Presentation the FullScreen control is not included. It should be included in ol3-dlf.json and a new build should be added.

Of course this control must be added in pageview plugin as well to be usable.

sebastian-meyer commented 6 years ago

Is this related to this branch: https://github.com/kitodo/kitodo-presentation/tree/fix-172-add-ol-fullscreen?

And is this branch ready to get merged?

sebastian-meyer commented 6 years ago

242 introduced a new OpenLayers build. Is this still relevant?

albig commented 6 years ago

242 doesn't bring the FullScreen control. But we (currently) won't use it anyway.

sebastian-meyer commented 6 years ago

Is there any chance that this is fixed anytime in the next months? Otherwise I'd close this issue and delete the branch https://github.com/kitodo/kitodo-presentation/tree/fix-172-add-ol-fullscreen

albig commented 6 years ago

I think, we can close this. The real fullscreen mode doesn't help us as we always exit fullscreen mode on paging. This is only useful for single images and maps.