search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
37 stars 45 forks source link

LABEL of physical structMap is ignored; ORDERLABEL is used instead #178

Closed albig closed 6 years ago

albig commented 7 years ago

The METS application profile Version 2.3 describes the physical document structure as follows:

The ORDERLABEL attribute can contain the pagination of the individual page according to the original. The LABEL attribute can include the foliation of the individual page or the specification of record side and track number.

In Kitodo.Presentation, the function _getPhysicalPages() ignores the LABEL and sets "label" as ORDERLABEL if present.

https://github.com/kitodo/kitodo-presentation/blob/master/dlf/common/class.tx_dlf_document.php#L1930

I would suggest, to use LABEL if present, else ORDERLABEL if present, else empty string.

sebastian-meyer commented 7 years ago

We should set ORDERLABEL and LABEL in _getPhysicalPages() and use whatever is reasonable later.

Von: Alexander Bigga Gesendet: Mon May 29 12:43:49 GMT+02:00 2017 An: kitodo/kitodo-presentation Cc: Subscribed Betreff: [kitodo/kitodo-presentation] LABEL of physical structMap is ignored; ORDERLABEL is used instead (#178)

The METS application profilehttp://dfg-viewer.de/fileadmin/groups/dfgviewer/METS_application_profile_2.3.pdf Version 2.3 describes the physical document structure as follows:

The ORDERLABEL attribute can contain the pagination of the individual page according to the original. The LABEL attribute can include the foliation of the individual page or the specification of record side and track number.

In Kitodo.Presentation, the function _getPhysicalPages() ignores the LABEL and sets "label" as ORDERLABEL if present.

I would suggest, to use LABEL if present, else ORDERLABEL if present, else empty string.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/kitodo/kitodo-presentation/issues/178, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABtwFz4cDn5pwp-qW4yO-lH2F_EJmWYMks5r-qFhgaJpZM4NpKZP.

sebastian-meyer commented 6 years ago

See #205: tx_dlf_document->physicalStructureInfo now contains @LABEL and @ORDERLABEL.