search

kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
37 stars 45 forks source link

Javascript Error in pageview plugin (basket feature) #239

Closed albig closed 6 years ago

albig commented 6 years ago

In current master, there is a javascript error in tx_dlf_pageview.js used by pageview plugin:

Uncaught TypeError: Cannot read property 'condition' of undefined (tx_dlf_pageview.js:424)

kitodo_presentation_pageview_error

chrizzor commented 6 years ago

This Javascript error occurs if the OpenLayer build has not all required classes. It wasn't possible for me to build the ol3-dlf.js with the ol3-dlf.json. But I included the required classes in the ol3-dlf.json. Unfortunately without testing. On the other hand with the full ol3.js this error doesn't occur.

albig commented 6 years ago

Ok. So we need to rebuild the openlayers build before the next release.

albig commented 6 years ago

@frank-ulrich-weber If you fix this issue: please follow the instruction in Readme.md: https://github.com/kitodo/kitodo-presentation/blob/master/dlf/lib/OpenLayers/README.md We need to use the SLUB fork and should investigate later on, if we could upgrade OL3.

sebastian-meyer commented 6 years ago

Fixed with #242