kitodo / kitodo-presentation

Kitodo.Presentation is a feature-rich framework for building a METS- or IIIF-based digital library. It is part of the Kitodo Digital Library Suite.
https://kitodo.org
GNU General Public License v3.0
37 stars 45 forks source link

Missing icons in TYPO3 backend #260

Closed stweil closed 6 years ago

stweil commented 6 years ago

The TYPO3 list view does not show icons for the Kitodo records, for example for the "Mandanten" record. We get this issue in 1.3.0 and 2.2.0 (2.2.0 worked in a test done 2018-01-18).

missing-icon

stweil commented 6 years ago

Maybe related: these icon files which are used in the code (see git grep iconfile) are missing in the source tree:

stweil commented 6 years ago

It looks like the four missing icons are part of the basket feature (unrelated to my initial issue). @chrizzor, what about those icons?

albig commented 6 years ago

I cannot reconstruct your issue. Your example with the library ("Mandanten") table is working for me in TYPO3 6.2 and 7.6 with Kitodo.Presentation 2.2.0. The file which is loaded in this case is /typo3conf/ext/dlf/res/icons/txdlflibraries.png, which is available.

typo3 typo3 cms 7 6 23 1

Could you inspect with your browser, which file should be loaded in your case?

stweil commented 6 years ago

I just tested again with both versions of Kitodo.Presentation. While the 1.3.0 instance still shows the problem, 2.2.0 now looks good. Maybe a cache clean up had fixed the problem there?

stweil commented 6 years ago

There remains the inconsistency between code and available images for the basket feature (mentioned above). Should that be a new issue, or can we handle it here? If we create a new issue, then the current issue can be closed: we don't need an update for 1.3.x.

In addition, the Kitodo icons on the left side (txdlfindexing.png, txdlfmodules.png, txdlfnewclient.png) use a design which does not fit with other TYPO3 icons there. But that's only cosmetics.

chrizzor commented 6 years ago

I added the missing icons again. I didn't notice that they were removed by the revert commit.

stweil commented 6 years ago

Thank you. Then I can close this issue here.