Inconsistent struct links in METS-files of ephemera

andre-hohmann commented 4 years ago

Problem

In the element <mets:structLink> of the exported METS-file for the issue, the following inconsistencies have been observed:

the images are assigned to all structure elements of , as for example "ephemera" or "year". This is not correct, because the images should be assigned only to the issue and the contained structure elements.
several duplicates are contained.
several not all images are assigned to the "issue". That might be related to the issue https://github.com/kitodo/kitodo-production/issues/3627.

Current state

Click to show the exported METS-File:

```xml ```

Solution

The <mets:structLink> should be correct.

Target status

Click to show the exported METS-File:

```xml ```

Examples

Examples 2.x

matthias-ronge commented 4 years ago

It is a hard rule that an image in internal METS format is only ever referenced at the lowest level, when exporting it is then automatically referenced at all levels above. The application only does what we said it should. Goal: We need to define an exception form so that there can be overarching structural elements for which this is not the case. year is an example for this.

Duplicates are a problem that I consider separately and have outsourced to its own issue #3678. The question is whether they pose a problem for the presentation (e.g. in the form of repetitive pages) or are simply not pretty.

For clarity, we should consider the assignment of the pages to the output in #3627, not here.

andre-hohmann commented 4 years ago

It is essential, that images are referenced only to the correct structure element or doctype!

andre-hohmann commented 4 years ago

It seems, as if it was not solved. I have created new processes and exported them. Should the issue be reopened?

Example

    <mets:structMap TYPE="LOGICAL">
        <mets:div ID="uuid-4238cd28-68f8-4c0b-ad74-e27e44d37eb8" TYPE="ephemera">
            <mets:mptr xlink:href="https://digital.slub-dresden.de/data/kitodo/ComeDaRaN_1703401751/ComeDaRaN_1703401751.xml" LOCTYPE="URL"/>
            <mets:div ID="uuid-cb70757f-04ec-48f1-aa3a-343473100ffe" TYPE="year">
                <mets:mptr xlink:href="https://digital.slub-dresden.de/data/kitodo/ComeDaRaN_1703401751-1796/ComeDaRaN_1703401751-1796.xml" LOCTYPE="URL"/>
                <mets:div ID="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568" ADMID="uuid-de2ab8cb-022e-3ec2-ba0f-6fb61ae6dd80 uuid-a0b8936c-ad0b-3996-9503-a65c25ad316a uuid-9ff5dcf8-228e-3bc2-a766-bb07a8e9fc25" ORDER="1">
                    <mets:div ID="uuid-7e6b239d-2db4-4df2-b1c6-dc9a7466e8d7" ORDER="1" ORDERLABEL="1796-09-05">
                        <mets:div ID="uuid-845e88e1-8bf0-4af1-a55b-1f7841b30972" DMDID="uuid-2a9ee701-5b0c-3200-8bf7-7c2baab8a0fa" TYPE="issue" ORDER="1"/>
                    </mets:div>
                </mets:div>
            </mets:div>
        </mets:div>
    </mets:structMap>
    <mets:structLink>
        <mets:smLink xlink:to="uuid-68249b25-9fe6-4c96-adbd-54c218cdfb6e" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-a7ae4c2e-0445-4af9-8866-cc51c7287a64" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-b7d0e1cc-e3f0-4b69-abef-8231e4d2740a" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-9df55174-d694-4e12-8095-d95bf08a77c0" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-68249b25-9fe6-4c96-adbd-54c218cdfb6e" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-a7ae4c2e-0445-4af9-8866-cc51c7287a64" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-b7d0e1cc-e3f0-4b69-abef-8231e4d2740a" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-9df55174-d694-4e12-8095-d95bf08a77c0" xlink:from="uuid-ad6c14b1-cd37-4621-8730-d6795b42f568"/>
        <mets:smLink xlink:to="uuid-68249b25-9fe6-4c96-adbd-54c218cdfb6e" xlink:from="uuid-7e6b239d-2db4-4df2-b1c6-dc9a7466e8d7"/>
        <mets:smLink xlink:to="uuid-a7ae4c2e-0445-4af9-8866-cc51c7287a64" xlink:from="uuid-7e6b239d-2db4-4df2-b1c6-dc9a7466e8d7"/>
        <mets:smLink xlink:to="uuid-b7d0e1cc-e3f0-4b69-abef-8231e4d2740a" xlink:from="uuid-7e6b239d-2db4-4df2-b1c6-dc9a7466e8d7"/>
        <mets:smLink xlink:to="uuid-9df55174-d694-4e12-8095-d95bf08a77c0" xlink:from="uuid-7e6b239d-2db4-4df2-b1c6-dc9a7466e8d7"/>
        <mets:smLink xlink:to="uuid-68249b25-9fe6-4c96-adbd-54c218cdfb6e" xlink:from="uuid-845e88e1-8bf0-4af1-a55b-1f7841b30972"/>
        <mets:smLink xlink:to="uuid-a7ae4c2e-0445-4af9-8866-cc51c7287a64" xlink:from="uuid-845e88e1-8bf0-4af1-a55b-1f7841b30972"/>
        <mets:smLink xlink:to="uuid-b7d0e1cc-e3f0-4b69-abef-8231e4d2740a" xlink:from="uuid-845e88e1-8bf0-4af1-a55b-1f7841b30972"/>
        <mets:smLink xlink:to="uuid-9df55174-d694-4e12-8095-d95bf08a77c0" xlink:from="uuid-845e88e1-8bf0-4af1-a55b-1f7841b30972"/>
    </mets:structLink>
</mets:mets>

andre-hohmann commented 4 years ago

I reopen the issue. It must be ensured that it works properly.

matthias-ronge commented 4 years ago

I can confirm that this is still not fixed with the current version.

kitodo / kitodo-production