search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
63 stars 63 forks source link

Faulty script task is completed #3673

Open matthias-ronge opened 4 years ago

matthias-ronge commented 4 years ago

Extracted from comment on issue #3279 by @mnscholz:

The exit code of the script doesn't have an effect on Kitodo. Setting exit 1 in the script will still render the task successful.

stefanCCS commented 4 years ago

Tested successfully with version 3.2-15.07.2020. If a script returns 1, the task will stay "open".

matthias-ronge commented 4 years ago

Needs to check what is the case here. Maybe the initial problem is different

Kathrin-Huber commented 2 years ago

@matthias-ronge please check if this is still an issue

stefanCCS commented 2 years ago

@Kathrin-Huber : In my opinion this works fine (already since Jul 2020 - see my comment above). I can confirm that it still runs fine in version 3.4.2 (sorry, have not installed 3.4.3 yet). --> this means, in my opinion this can be closed

@Kathrin-Huber and @matthias-ronge: Your decision ...