Closed andre-hohmann closed 1 year ago
@andre-hohmann three questions:
@solth : Good questions! I hope my answers are understandable.
1 We want to delete only the scans (original files). Reason: In Kitodo.Production 2.x, we only delete the scans (original files) and it would be helpful, if this could be possible in Kitodo.Production 3.x, too. It would be quicker and it would be avoided that users forget to delete the preview and thumbnail files (derivative files). Furthermore, the users should have as less opportunities to manipulate data as possible to avoid mistakes and problems.
2 You are absolutely right and it would be perfect, if the label could be adjusted to:
Aktualisierung der Anzahl der Bilddateien
Updating the number of image files
Other proposals are welcome!
3 The pagination in ORDERLABEL
should not be updated! Only the number of image files should be updated. Pagination is only lost, when the files are deleted. Use cases:
It must be avoided that the intellectual created pagination information is lost. But it is not expected that the pagination is automatically adjusted to the changes of the files. Thus, after the correction of the files, manual efforts are needed to adjust the pagination correctly. The remaining pagination information supports the corrections.
@andre-hohmann thanks for the response.
Just to avoid any misunderstandings:
If I understand you correctly, pressing the (then newly labeled) button after deleting some images should then:
mets:file
instances from the mets:fileGrp
elements and mets:fptr
elements from mets:structMap type="physical"
)ORDER
attribute of any affected pages after the deleted pages to correctly reflect the new order of the pages (which you refer to as "number of image files")Clicking the button will not:
ORDERLABEL
attribute of potentially updated pages, which would reflect changing existing paginationsIs this correct?
1 Delete images via the file system
We have a misunderstanding here, because nothing should be deleted, when the button is clicked.
When we delete image files in the file system, we proceed as follows:
When the button is clicked, the METS-file should be only updated according to the current amount of original image files - the ones from which the derivative files are created. The number should be the same for the generated image files.
2 Button label As discussed: we just use the proposed labels.
3 Update pagination
Clicking the button will not:
@solth , @henning-gerhardt : Thanks a lot for the discussion of this complex issue. I wrote some results as answers to Arveds questions. I hope that they are correct and understandable. If not, please correct - we could then avoid misunderstandings in the future.
In a meeting with @andre-hohmann and @henning-gerhardt we agreed on the following scope for this issue:
mets:file
elements are removed from the mets:fileGrp
s and corresponding mets:div
elements are removed from the physical mets:structMap
; additionally, the ORDER
attribute of all resulting mets:div
elements is updated to guarantee continuous values; the ORDERLABEL
attribute of remaining/resulting pages is not changed; new pages will receive the default ORDERVALUE
value -
; changing filenames of remaining filenames to those of deleted files can result in outdated ORDERLABEL
values which have to be corrected by user manually afterwards@andre-hohmann & @henning-gerhardt please add/correct any points I might have forgotten or not documented correctly here
I forgot one point we discussed: changes to the workpiece are only to be written to the meta.xml
file when the user explicitly clicks the Save
button, not implicitly after the action behind the now to be relabeled button is completed!
@solth : Thanks a lot for the summary! I have nothing to add/correct. Since your summary and my answers match, I think we have the same understanding regarding how to proceed.
@solth :
the button label is wrong, because it does not perform any kind of pagination, but instead adds or removes references to images to or from the METS file; what would be a more appropriate button label for this functionality in your opinion?
@henning-gerhardt am me would suggest the following label for the button:
Describe the bug In Kitodo.Production 2.x, the function "Read in pagination from images" is used to adjust the METS file (
<mets:fileSec>
,<mets:structLink>
, ...) according to the current amount of image files in the respective image folder. This is necessary, for example, after the deletion or the addition of image files. In Kitodo.Production 3.x the button exists, too (See: Beispiele), but without any functionality. Thus, it seems as if it is not possible to apply changes of images files to the METS file.To Reproduce Steps to reproduce the behavior:
Expected behavior If "Read in pagination from images" is clicked, the METS file is updated according to the current amount of image files.
Release
Desktop (please complete the following information):