search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
62 stars 63 forks source link

Rel. 3.4.3 Missing Option for KitodoScript - Dialogue #5315

Open m-kotzyba opened 2 years ago

m-kotzyba commented 2 years ago

Clicking on Possible Actions in the Processlist does not contain the Option to trigger the KitodoScript - Dialogue anymore. Since the option was available in 3.4.2, it seems that this Issue is related to 3.4.3, c.f. Images.

Is the option replaced or missing? Is there a possibility to trigger the dialogue, e.g. with short cuts? We use KitodoScrips in our productive system and would like to benefit from the new performance improvements in Rel. 3.4.3.

Kitodo Script Option 3 4 2

Kitodo Script Option 3 4 3

andre-hohmann commented 2 years ago

@m-kotzyba : There is a new authority called "Execute KitodoScript" or "KitodoScript ausführen". You have to add it to the roles.

It was introduced to avoid misuse of the KitodoScripts.

m-kotzyba commented 2 years ago

@andre-hohmann: Thanks for the hint. I checked that. Unfortunately, this authority seems not to be listed, not in "Edit role" --> authority and not in the tab "Authority". Having a look in the data base kitodo.authority confirms not entry named “kitodoscript” or something like that. The Release Note for 3.4.3 "there is no database change since release 3.4.0 so no migration.sql is needed" underlines that nothing happened here.

So, what to do now except to wait for 3.4.4? Maybe a migration.sql would help or a small instruction to update the data base manually.

henning-gerhardt commented 2 years ago

Fast and "ugly" workaround is to apply the content of https://github.com/kitodo/kitodo-production/blob/master/Kitodo-DataManagement/src/main/resources/db/migration/V2_108__Add_authority_to_run_Kitodo_Scripts.sql to get this missing authority available.

m-kotzyba commented 2 years ago

Worked. Thx :)

matthias-ronge commented 1 year ago

@henning-gerhardt This isn’t a work-around, but the described problem is caused by an incomplete migration, so this is the only and correct fix.

m-kotzyba commented 1 year ago

I can confirm that this solution is quite solid (not "ugly" at all) and so far necessary because it seems that:

  1. No migration.sql is available for the upgrade from 3.4.2 to 3.4.3 (where the change happened) and
  2. Also in the "migration_3-4-3_to_3-5-0.sql" the 'runKitodoScript_clientAssignable' - Value was not set in the table "authority"

Nevertheless, the kitodo_3-5-0.sql from the new Release 3.5.0 contains 'runKitodoScript_clientAssignable' (kitodo_3-4-3.sql not), so that new Kitodo installations do not have this issue. In other words: Only institutions starting at 3.4.3 or coming from 3.4.2 have to add 'runKitodoScript_clientAssignable' manually (assuming they always apply the provided data base migration scripts step by step).