search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
63 stars 63 forks source link

Update PrimeFaces #5528

Open solth opened 1 year ago

solth commented 1 year ago

Kitodo.Production should be updated from PrimeFaces 8 to the current version 12.

Related issues:

markusweigelt commented 1 year ago

@solth is it possible to remove the lable "improvement", cause in my option this lable misleads the need for Kitodo.Production?

solth commented 6 months ago

Votes: 3

stweil commented 2 months ago

Does anybody already know which changes (in addition to updated dependencies) are required?

Update 8 -> 10.0.0:

Update 10.0.0 -> 11.0.0:

Update 11.0.0 -> 12.0.0:

Update 12.0.0 -> 13.0.10:

Update 13.0.0 -> 14.0.2:

stweil commented 2 months ago

@solth is it possible to remove the lable "improvement", cause in my option this label misleads the need for Kitodo.Production?

Isn't it even a bug fix because of the mentioned related issue, so the label "bug" should be added?

markusweigelt commented 2 months ago

I tried version 10.0.0 at the end of 2021, and it appeared somewhat broken. For example, FontAwesome was dropped because PrimeFaces now includes its own icons, called PrimeIcons. (Manually including FontAwesome might be an option.) You can find an overview of the changes in the "Migration Guide".

In addition to updating PrimeFaces, the Selenium tests will likely need to be adjusted since the HTML structure or selectors may have changed.

Isn't it even a bug fix because of the mentioned related issue, so the label "bug" should be added?

The label "bug" seems more relevant to the current version and might be somewhat misleading. It would be better to use "improvement" or, additionally, the label "blocking" to describe the issue accurately. In the past, some institutions have hesitated to use Kitodo.Production because it supports an outdated Java version. Updating PrimeFaces also necessitates Java Update.