I stumbled over different problems.
1) The checkbox "Bilder validieren" as attribute of a task in the workflow editor has no effect. Even the image validation logic in the WorkflowControllerService is not checking for that attribute when the task is closed. Instead it is checking if the Task is of type typeImagesWrite. This is confusing.
2) This validity check has a very narrow definition of what is considered as valid. (see also https://github.com/kitodo/kitodo-production/issues/5007). The validity of images has probably to include more things. For example
3) Is there any check for the actual file types? It seems that it is allowed right now to put TIFFs in a folder which was marked as JPEG-folder. I stumbled over that, when i mis-configured my test system and set the folder with the originals to JPEG instead of TIFFs. The system let me put TIFF files in the folder. I only noticed there was something wrong when i tried to use the "upload media" feature, uploaded Tiffs and no derivatives where created.
solth
commented
1 year ago
Is your feature request related to a problem? Please describe. The validation of images in Kitodo should be implemented more coherently and be enhanced. What seems to be implemented are mostly checks for images which are not assigned to a structural element as part of the metadata validation https://github.com/kitodo/kitodo-production/blob/5b60965afb8a9512b0021b416ad98291971e66a4/Kitodo-Validation/src/main/java/org/kitodo/validation/metadata/MetadataValidation.java#L121-L122) But as far as i can see, there is no real image validation implemented.
I stumbled over different problems. 1) The checkbox "Bilder validieren" as attribute of a task in the workflow editor has no effect. Even the image validation logic in the
WorkflowControllerServiceis not checking for that attribute when the task is closed. Instead it is checking if the Task is of typetypeImagesWrite. This is confusing.https://github.com/kitodo/kitodo-production/blob/9826e41483c3ebb398925d9de8fe07fa07af2f95/Kitodo/src/main/java/org/kitodo/production/services/workflow/WorkflowControllerService.java#L215-L220
2) This validity check has a very narrow definition of what is considered as valid. (see also https://github.com/kitodo/kitodo-production/issues/5007). The validity of images has probably to include more things. For example
3) Is there any check for the actual file types? It seems that it is allowed right now to put TIFFs in a folder which was marked as JPEG-folder. I stumbled over that, when i mis-configured my test system and set the folder with the originals to JPEG instead of TIFFs. The system let me put TIFF files in the folder. I only noticed there was something wrong when i tried to use the "upload media" feature, uploaded Tiffs and no derivatives where created.