search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
58 stars 64 forks source link

Automatically created images don't appear in `meta.xml` #6065

Open mnscholz opened 1 month ago

mnscholz commented 1 month ago

Describe the bug

I have a workflow script step that calls a shell script that generates derivative images of the main tiffs. The directory where the images get stored is declared in the project settings as shown below:

Although it says that the images should get included in the METS, they will not appear as a mets:fileGrp in the meta.xml during the whole workflow, only in the exported METS they are included correctly.

In the workflow script step, the properties for reading/writing/validating images are set.

Expected behavior The created images should appear in the meta.xml directly after the step has finished.

Edit: / Note: The meta.xml (or more precisely its mets:fileSec) does only seem to get updated when clicking the Save button in the metadata editor, independently of the current process status. On the other side, the step's properties don't seem to have any effect on updating/re-reading the image directories. This seems to be counter-intuitive as to the properties' namings.

This issue mentions this behavior of the Save button. Can this behavior be triggered somehow in an automatic step?

Screenshots grafik

Release 3.5.0

BartChris commented 1 month ago

https://github.com/kitodo/kitodo-production/pull/4450

Original issue: https://github.com/kitodo/kitodo-production/issues/3333 To elaborate: It should be possible to define a automatic script task after your image generation step. In this task you call the following kitodo action: action:searchForMedia, to add the refrences to the METS file. I have not tested it myself but it should work. Would that functionality help you?

mnscholz commented 1 month ago

Yes that helps, thanks a lot! Is it also possible to trigger the action from outside Kitodo, ie. from the shell script that got called by Kitodo?

I leave this issue open as I still consider it a bug that the workflow step properties write/validate images won't update the meta.xml, which IMO is the expected behaviour.

BartChris commented 1 month ago

Yes that helps, thanks a lot! Is it also possible to trigger the action from outside Kitodo, ie. from the shell script that got called by Kitodo?

Not yet, as far as i know. There is an open Pull Request for that functionality: https://github.com/kitodo/kitodo-production/pull/6013