search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
64 stars 63 forks source link

Remove `@Tag("isPositive(long)")` statements which cause build warnings #6116

Closed stweil closed 4 months ago

stweil commented 4 months ago

See CI protocol.

stweil commented 4 months ago

The lines were added in pull request #5756.

stweil commented 4 months ago

I agree, but I don't know how the right fix should look like. Therefore the current commit only removes the ignored tags to avoid warnings.

matthias-ronge commented 4 months ago

My mistage. But I didn't know that either: These tags are a problem because they contain parentheses. But in general, we can use these tages.

Found here: https://junit.org/junit5/docs/5.3.0/api/org/junit/jupiter/api/Tag.html

stweil commented 4 months ago

Superseded by PR #6119.