search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
63 stars 63 forks source link

CI: Store Kitodo war file as build artifact for download #6128

Open stweil opened 2 months ago

stweil commented 2 months ago

See example. CI artifacts are always ZIP files. In this case it is the ZIP file kitodo.zip which includes kitodo-3.7.0-SNAPSHOT.war (which itself is a ZIP file).

henning-gerhardt commented 2 months ago

What are the benefit to have this except more used space inside the CI build artifacts which is never or only after a long time get deleted in any active fork?

stweil commented 2 months ago

Build artifacts are deleted automatically, and it is also possible to specify the retention time from 1 up to 90 days (which is the default) if this is desired. Project maintainers can also delete artifacts manually.

The war file which was created by the CI can be downloaded and used locally for tests.

stweil commented 2 months ago

Vielleicht sollten wir weitere Artefakte bereitstellen, z. B. die failsafe-reports:

Error:  Please refer to /home/runner/work/kitodo-production/kitodo-production/Kitodo/target/failsafe-reports for the individual test results.
henning-gerhardt commented 2 months ago

Build artifacts are deleted automatically, and it is also possible to specify the retention time from 1 up to 90 days (which is the default) if this is desired. Project maintainers can also delete artifacts manually.

Maybe this is here not configured as I can access 1.260 executed CI actions which goes back at least one year. Currently a war file is more then 130 MB big and then you can calculate how much storage is needed / reserved to provide this files. This is only on this repository. I did not count on how many more fork repositories the same or even more CI runs are executed.

The war file which was created by the CI can be downloaded and used locally for tests.

Who need this files? As a developer I can create the war file much faster then let a CI action execute and downloading this file. As an admin I would go to my (contract) developer of choice that he / she / it can provide me this file if needed. Using this file to run local tests should be done carefully as they contain maybe changes which are still under development or not stable as you expect.

Vielleicht sollten wir weitere Artefakte bereitstellen, z. B. die failsafe-reports:

This (failsafe-reports) could be a valid point but I think there are already existing mechanism to get the content of the reports better displayed then now and who would download so many single report files?

In my opinion as my last comment here:

stweil commented 2 months ago

Maybe this is here not configured as I can access 1.260 executed CI actions which goes back at least one year.

Lieber Henning, probiere es bitte aus. Du wirst keine Logdaten sehen, die älter als 90 Tage sind. Lediglich grobe Metadaten sind dann noch sichtbar.

stweil commented 2 months ago

This (failsafe-reports) could be a valid point but I think there are already existing mechanism to get the content of the reports better displayed then now and who would download so many single report files?

Momentan kenne ich keinen existierenden Weg, wie man an den ausführlichen Bericht kommen kann. Eine ZIP-Datei mit den wenigen benötigten Berichten würde ich daher gerne herunterladen, lokal auspacken und mir dann den gewünschten Bericht anschauen.

henning-gerhardt commented 2 months ago

Lieber Henning, probiere es bitte aus. Du wirst keine Logdaten sehen, die älter als 90 Tage sind. Lediglich grobe Metadaten sind dann noch sichtbar.

Even if this is true and the files are "only" available for a shorter time period this is a waste of space even for this time.

henning-gerhardt commented 2 months ago

Momentan kenne ich keinen existierenden Weg, wie man an den ausführlichen Bericht kommen kann. Eine ZIP-Datei mit den wenigen benötigten Berichten würde ich daher gerne herunterladen, lokal auspacken und mir dann den gewünschten Bericht anschauen.

Running the tests on your local system is no way for you? If no then why should everyone do this only for you?

henning-gerhardt commented 2 months ago

I'm stop here to comment and to read as again this is a circle discussion.