search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
63 stars 63 forks source link

Change groupId of Kitodo-Validation #6160

Open stweil opened 2 months ago

stweil commented 2 months ago

~No other module has a groupId, and there is no obvious reason for one here.~

The other modules have no explicit groupId, but use org.kitodo implicitly.

stweil commented 2 months ago

Maybe using an explicit <groupId>org.kitodo</groupId> for all modules would be an even better solution.

stweil commented 2 months ago

~Some tests fail with this change. I still have to find the reason.~

stweil commented 2 months ago

As removing the groupId breaks the CI tests, I now changed it to the default value "org.kitodo" which seems to work.

stweil commented 2 months ago

I noticed the strange setting for Kitodo-Validation while running ls ~/.m2/repository/org/kitodo for another issue:

kitodo          kitodo-data-format  kitodo-image-management         kitodo-query-url-import
kitodo-api      kitodo-data-management  kitodo-longtermpreservation-validation  kitodo-validation
kitodo-command      kitodo-docket       kitodo-persistentidentifier     kitodo-xml-schemaconverter
kitodo-data-editor  kitodo-file-management  kitodo-production           validation

The list shows the old directory validation which looks strange here. With the PR, it is replaced by kitodo-validation which uses the same naming convention as all other modules.

stweil commented 2 months ago

The latest build failure is unrelated to this PR (see issue #6138).