search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
63 stars 63 forks source link

Role list not filtered by client #6261

Open solth opened 1 week ago

solth commented 1 week ago

Describe the bug Nearly all lists in Kitodo.Production are filtered by the users currently selected client. Two exceptions are the "Clients" list itself and the "Roles" list on the "Users" page. While it can be argued that the "Clients" list is a justified exception, the "Roles" list should definitely be filtered by client. Instead it is actually sortable by clients, but that is of little use and discloses information that shouldn't be visible to the user in this situation, since there is always a specific client selected in the system that all displayed information should be based upon.

To Reproduce Steps to reproduce the behavior:

  1. Go to "Users" page
  2. Click on tab "Roles"
  3. See error

Expected behavior The role list should be filtered by client, like all other lists in the system.

henning-gerhardt commented 1 week ago

If role list only visible by current used client it made it more complex to compare roles between clients :-(

solth commented 1 week ago

While I do see your point I think hardening (might even say "fixing") our multi client system has to have higher priority.

henning-gerhardt commented 1 week ago

While I do see your point I think hardening (might even say "fixing") our multi client system has to have higher priority.

I know and we have even a multi client system but with this "fix" there imore work on adjusting the roles after updating to a new version or on need (f.e. security reasons) to change them.