search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
64 stars 63 forks source link

Sticky header in metadata column breaks scrolling #6291

Closed thomaslow closed 2 weeks ago

thomaslow commented 3 weeks ago

The metadata column of the metadata editor cannot be scrolled correctly any more after #6233. This breaks #6285.

A similar problem is also present in the structure tree column (when using tab to navigate to the "add comment" button).

To Reproduce Steps to reproduce the behavior:

  1. Open metadata editor
  2. Try to scroll all the way down in the metadata column

Expected behavior Scrolling should work correctly (all the way down).

Screenshots

https://github.com/user-attachments/assets/68c2c9a9-9fb5-43bc-94b3-37b174255c87

Release Master

oliver-stoehr commented 2 weeks ago

A similar problem is also present in the structure tree column (when using tab to navigate to the "add comment" button).

@thomaslow I could not reproduce the mentioned error in the structure tree. Can you elaborate on how to reproduce the error?

thomaslow commented 2 weeks ago

You can observe it in the video. Click on the structure tree (such that it is focused with a blue border), and then use the tab key to change the focus to the next focus-able element, see tabIndex.

In theory, we could disable the tab selection for the comment button. Ideally, there is a solution that preserves accessibility, see #5890.