search

kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
64 stars 63 forks source link

No check for duplicate titles when creating the process using the process form #6303

Open BartChris opened 9 hours ago

BartChris commented 9 hours ago

Describe the bug There seems to be no validation for a duplicate process title happening when i use the standard way to create a new process using the CreateProcess form.

Kitodo configuration seems is correct

# Configure whether each process needs to have a unique title or not
uniqueProcessTitles=true

When checking the code in importProcessHierarchy i see no call of processTempProcess where this validation would take place.

https://github.com/kitodo/kitodo-production/blob/74b76be07a672701faec2da329932fd4283e6af1/Kitodo/src/main/java/org/kitodo/production/services/data/ImportService.java#L506

https://github.com/kitodo/kitodo-production/blob/74b76be07a672701faec2da329932fd4283e6af1/Kitodo/src/main/java/org/kitodo/production/services/data/ImportService.java#L1171

To Reproduce Steps to reproduce the behavior:

  1. Create a process with title 'ABC' using the normal create process form
  2. Try to create another process with the same title 'ABC'
  3. The duplicate title is not prevented

Expected behavior It should not be possible to create processes with duplicate titles, when the configuration disallows that.

Release Kitodo 3.7.1, Master

solth commented 9 hours ago

I think this describes the same problem as is related to #6055