kitodo / kitodo-production

Kitodo.Production is a workflow management tool for mass digitization and is part of the Kitodo Digital Library Suite.
http://www.kitodo.org/software/kitodoproduction/
GNU General Public License v3.0
59 stars 65 forks source link

Duplicated classes with same package structure #654

Closed henning-gerhardt closed 7 years ago

henning-gerhardt commented 7 years ago

While debugging for #653 I got some debugging trouble for class SimplePDFMetadataExtractor.

This and other classes are provided by kitodo-contentserver-2.0.0.jarand simplemets-0.0.1-SNAPSHOT.jar.

A similar duplication exists between kitodo-contentserver-2.0.0.jar and util-0.0.1-SNAPSHOT.jar.

For jar files simplemets-0.0.1-SNAPSHOT.jar and util-0.0.1-SNAPSHOT.jar does not exists any source code. For me it looks like that

Having duplicated classes with same package structure causes a big problem if they are outdated or different changed you never know which version is used.

So I would prefer to remove simplemets-0.0.1-SNAPSHOT.jar and util-0.0.1-SNAPSHOT.jar files in favour for source code available versions.

stweil commented 7 years ago

Great, that sounds as if two more jar files with unknown origin and without sources could be removed.

henning-gerhardt commented 7 years ago

Fixed by PR #656