search

kitodo / kitodo-ugh

Kitodo.UGH Library
2 stars 10 forks source link

Fixes #71 #72

Closed matthias-ronge closed 6 years ago

matthias-ronge commented 6 years ago

fixes #71

henning-gerhardt commented 6 years ago

Without tests I can not reproduce it before or after applying your patch as we did not use this feature and I have no process with this kind of meta data.

stweil commented 6 years ago

See also https://github.com/intranda/ugh/blob/master/ugh/src/ugh/dl/DocStruct.java#L565 which looks like the fixed code. Commit https://github.com/intranda/ugh/commit/7f699d498b270a9abee90cdcaa18c29858d69927 fixed the problem and is identical to the current pull request. Are there more old fixes in the Intranda fork which we should backport?

henning-gerhardt commented 6 years ago

@stweil: Do not ask me as I did not know this if there are more bugs and / or bug fixes in other forks of this library. If some body did some fixing and did not offer this as a pull request against this repo then I did not know about this bug fixing.