kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

File / FileCache #10

Closed bytinbit closed 6 years ago

bytinbit commented 6 years ago

RSVP for the structure of the File-Class, it determines everything else.

codecov[bot] commented 6 years ago

Codecov Report

Merging #10 into master will increase coverage by 1.5%. The diff coverage is 97.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #10     +/-   ##
=========================================
+ Coverage    93.9%   95.41%   +1.5%     
=========================================
  Files          19       30     +11     
  Lines         525      981    +456     
  Branches       29       53     +24     
=========================================
+ Hits          493      936    +443     
- Misses         26       34      +8     
- Partials        6       11      +5
Impacted Files Coverage Δ
src/kitovu/sync/plugin/smb.py 91.17% <100%> (+0.13%) :arrow_up:
tests/sync/test_syncing.py 100% <100%> (ø) :arrow_up:
tests/conftest.py 100% <100%> (ø) :arrow_up:
tests/helpers/dummyplugin.py 100% <100%> (ø) :arrow_up:
src/kitovu/sync/syncplugin.py 100% <100%> (ø) :arrow_up:
tests/test_filecache.py 100% <100%> (ø)
tests/test_dummyplugin.py 100% <100%> (ø) :arrow_up:
src/kitovu/sync/syncing.py 94.11% <87.5%> (-5.89%) :arrow_down:
src/kitovu/sync/filecache.py 96.82% <96.82%> (ø)
src/kitovu/gui/startscreen.py 100% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea31bfe...8126026. Read the comment docs.

The-Compiler commented 6 years ago

Oh, looks like there's some issues with tests on Windows, and pylint/mypy. Will fix them tomorrow, but please take a look whenever you have the time to get some free code feedback from those tools :wink:

The-Compiler commented 6 years ago

Fixed everything up and merged! :tada: Please take a look at the commits I pushed above when you get the time, but it's mostly small stuff.