ThunderKey commented 6 years ago

jsonschema itself would only raise the first error. With my custom validator I've created a merged error, which would display all errors.

The kitovu validate command prints all errors of the base document (missing root-keys or invalid formats) and aborts. If there are no errors in the base document it prints all errors for each plugin.

I've recreated the Pipfile.lock file. It removed a few packages and it still works without them. @The-Compiler are these necessary? Especially it's a bit strange that configparser was added twice

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fe52fd0). Click here to learn what that means. The diff coverage is 96.93%.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   96.33%           
=========================================
  Files             ?       30           
  Lines             ?     1090           
  Branches          ?       59           
=========================================
  Hits              ?     1050           
  Misses            ?       30           
  Partials          ?       10

Impacted Files	Coverage Δ
src/kitovu/sync/filecache.py	`96.82% <ø> (ø)`
src/kitovu/sync/syncplugin.py	`100% <100%> (ø)`
tests/sync/test_syncing.py	`100% <100%> (ø)`
src/kitovu/utils.py	`93.02% <100%> (ø)`
tests/helpers/dummyplugin.py	`100% <100%> (ø)`
src/kitovu/sync/syncing.py	`95.23% <100%> (ø)`
src/kitovu/sync/plugin/smb.py	`91.42% <100%> (ø)`
tests/sync/test_smb.py	`100% <100%> (ø)`
src/kitovu/cli.py	`66.66% <42.85%> (ø)`
src/kitovu/sync/settings.py	`94.64% <92.85%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe52fd0...b4d9a55. Read the comment docs.