search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Initial GUI #15

Closed The-Compiler closed 6 years ago

The-Compiler commented 6 years ago

recgif

codecov[bot] commented 6 years ago

Codecov Report

Merging #15 into master will increase coverage by 1.55%. The diff coverage is 94.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   91.02%   92.58%   +1.55%     
==========================================
  Files          16       25       +9     
  Lines         468      782     +314     
  Branches       28       39      +11     
==========================================
+ Hits          426      724     +298     
- Misses         36       51      +15     
- Partials        6        7       +1
Impacted Files Coverage Δ
src/kitovu/cli.py 0% <0%> (ø) :arrow_up:
src/kitovu/gui/app.py 0% <0%> (ø)
src/kitovu/gui/syncscreen.py 100% <100%> (ø)
tests/gui/test_mainwindow.py 100% <100%> (ø)
src/kitovu/gui/startscreen.py 100% <100%> (ø)
src/kitovu/gui/confscreen.py 100% <100%> (ø)
tests/gui/test_confscreen.py 100% <100%> (ø)
tests/gui/test_syncscreen.py 100% <100%> (ø)
tests/gui/test_startscreen.py 100% <100%> (ø)
src/kitovu/gui/mainwindow.py 96.66% <96.66%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa617c4...b13b2ac. Read the comment docs.

The-Compiler commented 6 years ago

Soooo I accidentally ended up with 100% test coverage for the GUI code :laughing: Some platform-specific stuff in there, let's see what Travis/Appveyor say.

The-Compiler commented 6 years ago

Bleh, tests are failing to start on Windows. Looking into it.

The-Compiler commented 6 years ago 
C:\projects\kitovu>C:\Python36-x64\python.exe -c "from PyQt5 import QtCore"

C:\projects\kitovu>.\.tox\py36\Scripts\python.exe -c "from PyQt5 import QtCore"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: DLL load failed: The specified module could not be found.

C:\projects\kitovu>set PATH=%PATH%;C:\Python36-x64

C:\projects\kitovu>.\.tox\py36\Scripts\python.exe -c "from PyQt5 import QtCore"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: DLL load failed: %1 is not a valid Win32 application.
The-Compiler commented 6 years ago

Took a bit more effort than I thought, but I think this is finally ready now, with tests and all. I was mistaken when saying 100% coverage above, but I think it's pretty nicely covered for now.