search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Feature keep the order of moodle folders #19

Closed ThunderKey closed 6 years ago

ThunderKey commented 6 years ago

Open Issue: Test module sections with illegal chars in windows

The-Compiler commented 6 years ago

The branch should probably be based on master and not your docs branch?

The-Compiler commented 6 years ago

Open Issue: Test module sections with illegal chars in windows

Seems like a general issue that might appear in other plugins as well. We should probably strip some special chars from local filenames - but that should be a separate story, IMHO.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@00b51d8). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   91.71%           
=========================================
  Files             ?       31           
  Lines             ?     1292           
  Branches          ?       82           
=========================================
  Hits              ?     1185           
  Misses            ?       95           
  Partials          ?       12
Impacted Files Coverage Δ
src/kitovu/sync/plugin/moodle.py 35.1% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00b51d8...edd4552. Read the comment docs.

ThunderKey commented 6 years ago

Damn it, I was in the wrong branch....

Seems like a general issue that might appear in other plugins as well. We should probably strip some special chars from local filenames - but that should be a separate story, IMHO.

I think that's very important behaviour, otherwise it could break in the usability tests. I could add it in this PR. Do you know of a built in way? Otherwise I'll research illegal chars for linux, mac and windows and replace those.

The-Compiler commented 6 years ago

I'd prefer having a separate PR, IMHO our PRs were a bit too big lately :wink:

Not aware of a built-in way for this, but I wrote this for qutebrowser some while ago and it seems to work well: https://github.com/qutebrowser/qutebrowser/blob/v1.2.1/qutebrowser/utils/utils.py#L490-L508

The-Compiler commented 6 years ago

Taking the freedom to rebase and force-push this to clean things up.