ThunderKey commented 6 years ago

Oh yeah...

The problem would be Folders with slashes in them. This would lead to sub folders, which could be confusing. E.g. "17./18. of March"

ThunderKey commented 6 years ago

But I guess it's the best option. The only alternative I'd see would be a "translation" dictionary, which would make everything much more complicated

codecov[bot] commented 6 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.11%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
+ Coverage   91.28%   91.4%   +0.11%     
=========================================
  Files          31      32       +1     
  Lines        1194    1210      +16     
  Branches       74      76       +2     
=========================================
+ Hits         1090    1106      +16     
  Misses         93      93              
  Partials       11      11

Impacted Files	Coverage Δ
tests/test_utils.py	`100% <100%> (ø)`
src/kitovu/utils.py	`94% <100%> (+0.97%)`	:arrow_up:
src/kitovu/sync/syncing.py	`92.64% <100%> (ø)`	:arrow_up:
tests/sync/test_syncing.py	`100% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3f9fd4...9c29c74. Read the comment docs.

The-Compiler commented 6 years ago

I opened EPJ-94 for how to handle slashes in filenames. Like you say, it'd be nice to handle this in a nicer way.

kitovu-bot / kitovu

added a sanitize_filename method #20

Codecov Report