Closed ThunderKey closed 6 years ago
:exclamation: No coverage uploaded for pull request base (
master@e523d39
). Click here to learn what that means. The diff coverage is28.57%
.
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage ? 90.99%
=========================================
Files ? 32
Lines ? 1310
Branches ? 85
=========================================
Hits ? 1192
Misses ? 105
Partials ? 13
Impacted Files | Coverage Δ | |
---|---|---|
src/kitovu/sync/filecache.py | 89.85% <28.57%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e523d39...6969bd9. Read the comment docs.
LGTM now!
Oh, something I forgot: It'd be nice to add a test for this...
Added tests in #35
Tested with:
rm ~/.local/share/kitovu/filecache.json
kitovu sync
FileState.NO_CHANGES
and does nothing (but update teh filecache)FileState.BOTH_CHANGED
and gets downloadedMaybe we could make the
filecache.File
class wrappinglocal_digest
andremote_digest
. We then could move the_compare_digests
to that class as well instead of having theFileCache
do everything