kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Feature handle new local files #30

Closed ThunderKey closed 6 years ago

ThunderKey commented 6 years ago

Tested with:

Maybe we could make the filecache.File class wrapping local_digest and remote_digest. We then could move the _compare_digests to that class as well instead of having the FileCache do everything

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e523d39). Click here to learn what that means. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   90.99%           
=========================================
  Files             ?       32           
  Lines             ?     1310           
  Branches          ?       85           
=========================================
  Hits              ?     1192           
  Misses            ?      105           
  Partials          ?       13
Impacted Files Coverage Δ
src/kitovu/sync/filecache.py 89.85% <28.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e523d39...6969bd9. Read the comment docs.

The-Compiler commented 6 years ago

LGTM now!

The-Compiler commented 6 years ago

Oh, something I forgot: It'd be nice to add a test for this...

ThunderKey commented 6 years ago

Added tests in #35