search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Use temppath instead of tmpdir across the codebase #32

Closed The-Compiler closed 6 years ago

The-Compiler commented 6 years ago

We have a temppath fixture returning a pathlib.Path for pytest's tmpdir because we need pathlib objects at some points. For consistency (and so we don't have to care about two slightly different APIs), just let's use temppath everywhere.

No JIRA issue because this took ~5min.

codecov[bot] commented 6 years ago

Codecov Report

Merging #32 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files          32       32              
  Lines        1307     1304       -3     
  Branches       83       83              
==========================================
- Hits         1194     1191       -3     
  Misses        102      102              
  Partials       11       11
Impacted Files Coverage Δ
tests/gui/test_confscreen.py 100% <100%> (ø) :arrow_up:
tests/sync/test_syncing.py 100% <100%> (ø) :arrow_up:
tests/gui/test_syncscreen.py 100% <100%> (ø) :arrow_up:
tests/test_dummyplugin.py 100% <100%> (ø) :arrow_up:
tests/sync/test_smb.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12303ab...3bbc6ec. Read the comment docs.