The-Compiler commented 6 years ago

The message is pretty ugly, but better than nothing:

ThunderKey commented 6 years ago

Cool! Is it possible enable the user to change the size of the window? I guess this would help.

The-Compiler commented 6 years ago

Turns out the config I used in tests before was invalid, which was breaking the tests now :laughing: - fixed!

I've looked into making the window resizable or automatically adjusting the width, but everything I could find was rather hacky. In the long run I think we should have something like a list of errors and "details" to fold out (hidden by default).

However, I think right now this is an okay-ish stop-gap solution until then.

codecov[bot] commented 6 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.16%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   89.48%   89.65%   +0.16%     
==========================================
  Files          30       30              
  Lines        1313     1344      +31     
  Branches       86       86              
==========================================
+ Hits         1175     1205      +30     
- Misses        124      126       +2     
+ Partials       14       13       -1

Impacted Files	Coverage Δ
tests/gui/test_confscreen.py	`100% <100%> (ø)`	:arrow_up:
src/kitovu/gui/confscreen.py	`92.1% <62.5%> (-7.9%)`	:arrow_down:
tests/test_filecache.py	`100% <0%> (ø)`	:arrow_up:
src/kitovu/sync/filecache.py	`93.5% <0%> (+2.59%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bfcc23...afe9695. Read the comment docs.

kitovu-bot / kitovu

Add config validation to the GUI #34

Codecov Report