search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

added a -h shortcut for the cli #41

Closed ThunderKey closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d4d03a6). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   89.55%           
=========================================
  Files             ?       30           
  Lines             ?     1350           
  Branches          ?       86           
=========================================
  Hits              ?     1209           
  Misses            ?      128           
  Partials          ?       13
Impacted Files Coverage Δ
src/kitovu/cli.py 71.21% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4d03a6...dfa5f9c. Read the comment docs.

The-Compiler commented 6 years ago

Just pushed a commit to simplify this a bit - I don't see the need for a variable we only use once, and we use {'foo': 'bar'} (and not dict(foo='bar')) to create dicts elsewhere so we should do so here, too.